Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2743773004: Revert "Infer types of instance methods before any other inference." (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Infer types of instance methods before any other inference." This reverts commit 8ad60b7c8bc8a9a9aa4f0cf2c3ddb6a61051385b. The change caused DDC break. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cc3946fca8a7adee4a55d11d78e2c6c2fe5e4db3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -83 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +0 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 5 chunks +4 lines, -56 lines 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-10 22:57:12 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as cc3946fca8a7adee4a55d11d78e2c6c2fe5e4db3 (presubmit successful).
3 years, 9 months ago (2017-03-10 22:57:22 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-10 22:58:53 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698