Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2743773004: Revert "Infer types of instance methods before any other inference." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/link.dart ('k') | pkg/analyzer/lib/src/task/strong_mode.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.task.dart; 5 library analyzer.src.task.dart;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/ast/standard_resolution_map.dart'; 10 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
(...skipping 3451 matching lines...) Expand 10 before | Expand all | Expand 10 after
3462 TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT); 3462 TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);
3463 // 3463 //
3464 // Infer instance members. 3464 // Infer instance members.
3465 // 3465 //
3466 if (context.analysisOptions.strongMode) { 3466 if (context.analysisOptions.strongMode) {
3467 InstanceMemberInferrer inferrer = new InstanceMemberInferrer( 3467 InstanceMemberInferrer inferrer = new InstanceMemberInferrer(
3468 typeProvider, 3468 typeProvider,
3469 new InheritanceManager( 3469 new InheritanceManager(
3470 resolutionMap.elementDeclaredByCompilationUnit(unit).library), 3470 resolutionMap.elementDeclaredByCompilationUnit(unit).library),
3471 typeSystem: context.typeSystem); 3471 typeSystem: context.typeSystem);
3472 inferrer.inferInstanceMethods(unit.element);
3473 inferrer.inferCompilationUnit(unit.element); 3472 inferrer.inferCompilationUnit(unit.element);
3474 } 3473 }
3475 // 3474 //
3476 // Record outputs. 3475 // Record outputs.
3477 // 3476 //
3478 outputs[RESOLVED_UNIT10] = unit; 3477 outputs[RESOLVED_UNIT10] = unit;
3479 outputs[CREATED_RESOLVED_UNIT10] = true; 3478 outputs[CREATED_RESOLVED_UNIT10] = true;
3480 } 3479 }
3481 3480
3482 /** 3481 /**
(...skipping 3072 matching lines...) Expand 10 before | Expand all | Expand 10 after
6555 6554
6556 @override 6555 @override
6557 bool moveNext() { 6556 bool moveNext() {
6558 if (_newSources.isEmpty) { 6557 if (_newSources.isEmpty) {
6559 return false; 6558 return false;
6560 } 6559 }
6561 currentTarget = _newSources.removeLast(); 6560 currentTarget = _newSources.removeLast();
6562 return true; 6561 return true;
6563 } 6562 }
6564 } 6563 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/src/summary/link.dart ('k') | pkg/analyzer/lib/src/task/strong_mode.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698