Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2743743002: Migrate WTF::LinkedHashSet/ListHashSet::removeLast() to ::pop_back() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::LinkedHashSet/ListHashSet::removeLast() to ::pop_back() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2743743002 Cr-Commit-Position: refs/heads/master@{#455792} Committed: https://chromium.googlesource.com/chromium/src/+/d80c4b7df762231c28fd4349a35cd4e4408d635f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 9 months ago (2017-03-09 16:00:34 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-09 16:03:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743743002/1
3 years, 9 months ago (2017-03-09 18:05:37 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:10:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d80c4b7df762231c28fd4349a35c...

Powered by Google App Engine
This is Rietveld 408576698