Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2743733002: Disable browser hit testing tests on Android (Closed)

Created:
3 years, 9 months ago by kenrb
Modified:
3 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable browser hit testing tests on Android Browser process hit testing was enabled on Android in r455559, along with the appropriate browser tests. Unfortunately on some builders these tests fail, due to coordinates being off skewed from expectations. The tests attempt to account for scale factor rounding error on Android that does not exist on other platforms, due to differently treatment of DSF, but apparently the variance can be quite high across devices. We need to investigate a way to work around this in browser tests. BUG=700007 TBR=creis@chromium.org Review-Url: https://codereview.chromium.org/2743733002 Cr-Commit-Position: refs/heads/master@{#455766} Committed: https://chromium.googlesource.com/chromium/src/+/6bc574cbc64fb6b9b29ac1bc8ea71e19ff327c41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M content/browser/site_per_process_browsertest.cc View 5 chunks +40 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743733002/1
3 years, 9 months ago (2017-03-09 15:58:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6bc574cbc64fb6b9b29ac1bc8ea71e19ff327c41
3 years, 9 months ago (2017-03-09 16:41:50 UTC) #6
Charlie Reis
3 years, 9 months ago (2017-03-09 17:05:20 UTC) #7
Message was sent while issue was closed.
LGTM, assuming this doesn't mean we have similar problems for real users.  (If
so, let's file a bug.)

Powered by Google App Engine
This is Rietveld 408576698