Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2743683003: MD Settings: use c/b/r/settings/OWNERS for the owners of more things (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: use c/b/r/settings/OWNERS for the owners of more things R=dpapad@chromium.org TBR=grt@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2743683003 Cr-Commit-Position: refs/heads/master@{#455996} Committed: https://chromium.googlesource.com/chromium/src/+/4d758b2c7100a4ce2db0c95889bb9fb0b9f421ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M chrome/app/OWNERS View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/OWNERS View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/test/data/webui/settings/OWNERS View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Dan Beam
3 years, 9 months ago (2017-03-10 02:59:04 UTC) #1
dpapad
lgtm
3 years, 9 months ago (2017-03-10 03:02:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743683003/1
3 years, 9 months ago (2017-03-10 03:03:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/382612)
3 years, 9 months ago (2017-03-10 03:09:58 UTC) #6
Dan Beam
TBR=grt@ for owners shuffling (with very little functional change)
3 years, 9 months ago (2017-03-10 03:15:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743683003/1
3 years, 9 months ago (2017-03-10 03:15:51 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 04:36:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d758b2c7100a4ce2db0c95889bb...

Powered by Google App Engine
This is Rietveld 408576698