Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2743673002: [turbofan] Revert invalid optimization of flooring division. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Revert invalid optimization of flooring division. The optimization NumberFloor(NumberDivide(lhs, rhs)) to NumberToInt32(NumberDivide(lhs, rhs)) for potentially negative lhs is not valid, since Math.floor rounds towards -infinity, whereas ToInt32 truncates. BUG=chromium:699282 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2743673002 Cr-Commit-Position: refs/heads/master@{#43699} Committed: https://chromium.googlesource.com/v8/v8/+/18be5d7057d794dbe3b663dfc17d3e512f2b55e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/compiler/typed-optimization.cc View 1 chunk +0 lines, -5 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-699282.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-09 12:22:33 UTC) #1
Jarin
lgtm
3 years, 9 months ago (2017-03-09 12:24:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743673002/1
3 years, 9 months ago (2017-03-09 12:24:49 UTC) #7
Michael Achenbach
Is this important enough to require a merge for tomorrow's canary?
3 years, 9 months ago (2017-03-09 12:55:24 UTC) #9
Benedikt Meurer
No, just correctness fix.
3 years, 9 months ago (2017-03-09 12:57:45 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 13:41:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/18be5d7057d794dbe3b663dfc17d3e512f2...

Powered by Google App Engine
This is Rietveld 408576698