Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2743653004: Remove IndexedDB experimental features flag. (Closed)

Created:
3 years, 9 months ago by pwnall
Modified:
3 years, 9 months ago
Reviewers:
jsbell, pfeldman
CC:
chromium-reviews, haraken, blink-reviews-bindings_chromium.org, cmumford, blink-reviews, kinuko+watch, jsbell+idb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IndexedDB experimental features flag. BUG=695202 Review-Url: https://codereview.chromium.org/2743653004 Cr-Commit-Position: refs/heads/master@{#456312} Committed: https://chromium.googlesource.com/chromium/src/+/5df3633d8d816fc675029f26d30c7bdc1c6e5f00

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -65 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 8 chunks +39 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBIndex.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
pwnall
PTAL?
3 years, 9 months ago (2017-03-10 00:59:51 UTC) #7
pwnall
PTAL?
3 years, 9 months ago (2017-03-10 00:59:52 UTC) #8
jsbell
lgtm https://codereview.chromium.org/2743653004/diff/1/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp (right): https://codereview.chromium.org/2743653004/diff/1/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp#newcode107 third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:107: // https://w3c.github.io/IndexedDB/#steps-to-convert-a-key-to-a-value Can you update that to: https://w3c.github.io/IndexedDB/#convert-a-key-to-a-value ...
3 years, 9 months ago (2017-03-10 16:32:44 UTC) #9
pwnall
Thank you very much for the feedback! https://codereview.chromium.org/2743653004/diff/1/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp (right): https://codereview.chromium.org/2743653004/diff/1/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp#newcode107 third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:107: // https://w3c.github.io/IndexedDB/#steps-to-convert-a-key-to-a-value ...
3 years, 9 months ago (2017-03-10 19:03:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743653004/20001
3 years, 9 months ago (2017-03-10 20:32:37 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/383134)
3 years, 9 months ago (2017-03-10 20:40:56 UTC) #19
pwnall
pfeldman@: Can you please review the changes to third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp and third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 ?
3 years, 9 months ago (2017-03-10 20:58:51 UTC) #21
pfeldman
lgtm
3 years, 9 months ago (2017-03-12 22:54:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743653004/20001
3 years, 9 months ago (2017-03-12 23:21:55 UTC) #24
pwnall
On 2017/03/12 22:54:03, pfeldman wrote: > lgtm Thank you very much for the weekend review!
3 years, 9 months ago (2017-03-12 23:22:16 UTC) #25
pfeldman
> Thank you very much for the weekend review! Heh, I'm on a business trip ...
3 years, 9 months ago (2017-03-12 23:38:13 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 00:56:15 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5df3633d8d816fc675029f26d30c...

Powered by Google App Engine
This is Rietveld 408576698