Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2743643002: [ObjC ARC] Converts ios/chrome/browser/ui/collection_view:collection_view to ARC. (Closed)

Created:
3 years, 9 months ago by stkhapugin
Modified:
3 years, 9 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org, gambard
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/collection_view:collection_view to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2743643002 Cr-Commit-Position: refs/heads/master@{#455785} Committed: https://chromium.googlesource.com/chromium/src/+/cecd74859106bdb9685acf37c93fe50ec156fc7c

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -36 lines) Patch
M ios/chrome/browser/ui/collection_view/BUILD.gn View 1 chunk +1 line, -0 lines 1 comment Download
M ios/chrome/browser/ui/collection_view/collection_view_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/collection_view/collection_view_controller.mm View 1 2 3 chunks +15 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/collection_view_model.mm View 1 3 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
stkhapugin
3 years, 9 months ago (2017-03-09 10:58:41 UTC) #3
stkhapugin
PTAL
3 years, 9 months ago (2017-03-09 14:56:05 UTC) #11
lpromero
lgtm https://codereview.chromium.org/2743643002/diff/40001/ios/chrome/browser/ui/collection_view/BUILD.gn File ios/chrome/browser/ui/collection_view/BUILD.gn (right): https://codereview.chromium.org/2743643002/diff/40001/ios/chrome/browser/ui/collection_view/BUILD.gn#newcode26 ios/chrome/browser/ui/collection_view/BUILD.gn:26: "collection_view_controller_test.h", Is this on the list to be ...
3 years, 9 months ago (2017-03-09 16:23:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743643002/40001
3 years, 9 months ago (2017-03-09 16:23:39 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 17:43:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cecd74859106bdb9685acf37c93f...

Powered by Google App Engine
This is Rietveld 408576698