Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2743613002: [debugger] remove outdated TODO. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove outdated TODO. We actually do want to make changes in debug-evaluate stick. R=jgruber@chromium.org BUG=v8:6071 Review-Url: https://codereview.chromium.org/2743613002 Cr-Commit-Position: refs/heads/master@{#43688} Committed: https://chromium.googlesource.com/v8/v8/+/0cce2bec1f36211eaf9839bf0b7622958cb9b4e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/debug/debug-evaluate.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-03-09 08:58:53 UTC) #1
jgruber
lgtm
3 years, 9 months ago (2017-03-09 09:07:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743613002/1
3 years, 9 months ago (2017-03-09 09:19:05 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 12:26:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0cce2bec1f36211eaf9839bf0b7622958cb...

Powered by Google App Engine
This is Rietveld 408576698