Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2712)

Unified Diff: chrome/browser/permissions/permission_context_base.h

Issue 2743603002: Reflect device status in geolocation permissions.request calls. (Closed)
Patch Set: Feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.h
diff --git a/chrome/browser/permissions/permission_context_base.h b/chrome/browser/permissions/permission_context_base.h
index 0863bde15e1a9642ccf91163ae4cb94e10708d18..066f7a5a8409c80f3b680eca98c619af20cc6e4b 100644
--- a/chrome/browser/permissions/permission_context_base.h
+++ b/chrome/browser/permissions/permission_context_base.h
@@ -90,6 +90,14 @@ class PermissionContextBase : public KeyedService {
const GURL& requesting_origin,
const GURL& embedding_origin) const;
+ // Update |result| with any modifications based on the device state. For
+ // example, if |result| is ALLOW but Chrome does not have the relevant
+ // permission at the device level, but will prompt the user, return ASK.
+ virtual PermissionResult UpdatePermissionStatusWithDeviceStatus(
+ PermissionResult result,
+ const GURL& requesting_origin,
+ const GURL& embedding_origin) const;
+
// Resets the permission to its default value.
virtual void ResetPermission(const GURL& requesting_origin,
const GURL& embedding_origin);

Powered by Google App Engine
This is Rietveld 408576698