Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: chrome/browser/permissions/permission_manager.cc

Issue 2743603002: Reflect device status in geolocation permissions.request calls. (Closed)
Patch Set: Feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_context_base.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_manager.cc
diff --git a/chrome/browser/permissions/permission_manager.cc b/chrome/browser/permissions/permission_manager.cc
index 3554494de2ce3bcee2d67350928704962bec582b..8b8ec66a6d4d814d36081552bcd618ca2e3c2f6d 100644
--- a/chrome/browser/permissions/permission_manager.cc
+++ b/chrome/browser/permissions/permission_manager.cc
@@ -440,10 +440,20 @@ PermissionStatus PermissionManager::GetPermissionStatus(
const GURL& requesting_origin,
const GURL& embedding_origin) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- return ContentSettingToPermissionStatus(
+ PermissionResult result =
GetPermissionStatus(PermissionTypeToContentSetting(permission),
- requesting_origin, embedding_origin)
- .content_setting);
+ requesting_origin, embedding_origin);
+
+ // TODO(benwells): split this into two functions, GetPermissionStatus and
+ // GetPermissionStatusForPermissionsAPI.
raymes 2017/03/10 04:37:13 One thought I had is that we may just want to leav
+ PermissionContextBase* context =
+ GetPermissionContext(PermissionTypeToContentSetting(permission));
+ if (context) {
+ result = context->UpdatePermissionStatusWithDeviceStatus(
+ result, requesting_origin, embedding_origin);
+ }
+
+ return ContentSettingToPermissionStatus(result.content_setting);
}
int PermissionManager::SubscribePermissionStatusChange(
« no previous file with comments | « chrome/browser/permissions/permission_context_base.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698