third_party/WebKit/Source/core/html/HTMLVideoElement.cpp - Issue 2743573003: Fix an issue in fullscreen detector when context is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2743573003: Fix an issue in fullscreen detector when context is destroyed (Closed)

Patch Set: addressed nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

index 9b915b95dd7d202ecce9b1fc70ecf556e1fd6bf5..f0c93fd8584c1bfad56cb8d4cb5ca9dc7dd233c4 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

@@ -76,6 +76,11 @@ DEFINE_TRACE(HTMLVideoElement) {

HTMLMediaElement::trace(visitor);

}

+void HTMLVideoElement::contextDestroyed(ExecutionContext* context) {

+ m_customControlsFullscreenDetector->contextDestroyed();

+ HTMLMediaElement::contextDestroyed(context);

bool HTMLVideoElement::layoutObjectIsNeeded(const ComputedStyle& style) {

return HTMLElement::layoutObjectIsNeeded(style);

}