Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2743573002: De-flake property sequence number unit test. (Closed)
Patch Set: Fix EXPECT_GT. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
index 4d8e2bb5a8cea6a96de438efec67770db247303d..e770539f028c02b239265ab568cbfb6ae50f6d46 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
@@ -1791,25 +1791,28 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees,
// Two content layers for the differentiated rect drawings and three dummy
// layers for each of the transform, clip and effect nodes.
EXPECT_EQ(5u, rootLayer()->children().size());
- EXPECT_EQ(1, propertyTrees().sequence_number);
+ int sequenceNumber = propertyTrees().sequence_number;
+ EXPECT_GT(sequenceNumber, 0);
for (auto layer : rootLayer()->children()) {
- EXPECT_EQ(1, layer->property_tree_sequence_number());
+ EXPECT_EQ(sequenceNumber, layer->property_tree_sequence_number());
}
update(artifact.build());
EXPECT_EQ(5u, rootLayer()->children().size());
- EXPECT_EQ(2, propertyTrees().sequence_number);
+ sequenceNumber++;
+ EXPECT_EQ(sequenceNumber, propertyTrees().sequence_number);
for (auto layer : rootLayer()->children()) {
- EXPECT_EQ(2, layer->property_tree_sequence_number());
+ EXPECT_EQ(sequenceNumber, layer->property_tree_sequence_number());
}
update(artifact.build());
EXPECT_EQ(5u, rootLayer()->children().size());
- EXPECT_EQ(3, propertyTrees().sequence_number);
+ sequenceNumber++;
+ EXPECT_EQ(sequenceNumber, propertyTrees().sequence_number);
for (auto layer : rootLayer()->children()) {
- EXPECT_EQ(3, layer->property_tree_sequence_number());
+ EXPECT_EQ(sequenceNumber, layer->property_tree_sequence_number());
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698