Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2743573002: De-flake property sequence number unit test. (Closed)
Patch Set: Fix EXPECT_GT. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/compositing/PaintArtifactCompositor.h" 5 #include "platform/graphics/compositing/PaintArtifactCompositor.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/test/test_simple_task_runner.h" 9 #include "base/test/test_simple_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
(...skipping 1773 matching lines...) Expand 10 before | Expand all | Expand 10 after
1784 .rectDrawing(FloatRect(0, 0, 100, 100), Color::white); 1784 .rectDrawing(FloatRect(0, 0, 100, 100), Color::white);
1785 artifact 1785 artifact
1786 .chunk(TransformPaintPropertyNode::root(), ClipPaintPropertyNode::root(), 1786 .chunk(TransformPaintPropertyNode::root(), ClipPaintPropertyNode::root(),
1787 EffectPaintPropertyNode::root()) 1787 EffectPaintPropertyNode::root())
1788 .rectDrawing(FloatRect(0, 0, 100, 100), Color::gray); 1788 .rectDrawing(FloatRect(0, 0, 100, 100), Color::gray);
1789 update(artifact.build()); 1789 update(artifact.build());
1790 1790
1791 // Two content layers for the differentiated rect drawings and three dummy 1791 // Two content layers for the differentiated rect drawings and three dummy
1792 // layers for each of the transform, clip and effect nodes. 1792 // layers for each of the transform, clip and effect nodes.
1793 EXPECT_EQ(5u, rootLayer()->children().size()); 1793 EXPECT_EQ(5u, rootLayer()->children().size());
1794 EXPECT_EQ(1, propertyTrees().sequence_number); 1794 int sequenceNumber = propertyTrees().sequence_number;
1795 EXPECT_GT(sequenceNumber, 0);
1795 for (auto layer : rootLayer()->children()) { 1796 for (auto layer : rootLayer()->children()) {
1796 EXPECT_EQ(1, layer->property_tree_sequence_number()); 1797 EXPECT_EQ(sequenceNumber, layer->property_tree_sequence_number());
1797 } 1798 }
1798 1799
1799 update(artifact.build()); 1800 update(artifact.build());
1800 1801
1801 EXPECT_EQ(5u, rootLayer()->children().size()); 1802 EXPECT_EQ(5u, rootLayer()->children().size());
1802 EXPECT_EQ(2, propertyTrees().sequence_number); 1803 sequenceNumber++;
1804 EXPECT_EQ(sequenceNumber, propertyTrees().sequence_number);
1803 for (auto layer : rootLayer()->children()) { 1805 for (auto layer : rootLayer()->children()) {
1804 EXPECT_EQ(2, layer->property_tree_sequence_number()); 1806 EXPECT_EQ(sequenceNumber, layer->property_tree_sequence_number());
1805 } 1807 }
1806 1808
1807 update(artifact.build()); 1809 update(artifact.build());
1808 1810
1809 EXPECT_EQ(5u, rootLayer()->children().size()); 1811 EXPECT_EQ(5u, rootLayer()->children().size());
1810 EXPECT_EQ(3, propertyTrees().sequence_number); 1812 sequenceNumber++;
1813 EXPECT_EQ(sequenceNumber, propertyTrees().sequence_number);
1811 for (auto layer : rootLayer()->children()) { 1814 for (auto layer : rootLayer()->children()) {
1812 EXPECT_EQ(3, layer->property_tree_sequence_number()); 1815 EXPECT_EQ(sequenceNumber, layer->property_tree_sequence_number());
1813 } 1816 }
1814 } 1817 }
1815 1818
1816 } // namespace blink 1819 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698