Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2743523004: bindings: Remove "inline" from NativeValueTraitsImpl methods (Closed)

Created:
3 years, 9 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 9 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Remove "inline" from NativeValueTraitsImpl methods These methods are all being declared and defined in the same place, so the inline keyword is redundant. BUG=685754 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2743523004 Cr-Commit-Position: refs/heads/master@{#456062} Committed: https://chromium.googlesource.com/chromium/src/+/0cc6a606ab68c783fe908f848f267b255da570ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -106 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h View 19 chunks +98 lines, -106 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raphael Kubo da Costa (rakuco)
PTAL. This one should be pretty simple compared to the latest CLs :)
3 years, 9 months ago (2017-03-10 13:32:29 UTC) #1
haraken
LGTM
3 years, 9 months ago (2017-03-10 13:32:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743523004/1
3 years, 9 months ago (2017-03-10 13:48:20 UTC) #4
Yuki
LGTM.
3 years, 9 months ago (2017-03-10 14:16:30 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 15:10:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cc6a606ab68c783fe908f848f26...

Powered by Google App Engine
This is Rietveld 408576698