Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2743523003: Remove non-MD code from screen_tray_item.cc (Closed)

Created:
3 years, 9 months ago by mohsen
Modified:
3 years, 9 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD code from screen_tray_item.cc Removed non-MD code form ScreenStatusView and ScreenTrayView classes. BUG=687808 TEST=none Review-Url: https://codereview.chromium.org/2743523003 Cr-Commit-Position: refs/heads/master@{#456413} Committed: https://chromium.googlesource.com/chromium/src/+/5d5a66859c4e2a7b8f5b779f1525b361872e8082

Patch Set 1 #

Patch Set 2 : Included missing headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M ash/common/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.cc View 1 3 chunks +4 lines, -21 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (20 generated)
mohsen
Please take a look...
3 years, 9 months ago (2017-03-10 20:48:48 UTC) #18
tdanderson
lgtm
3 years, 9 months ago (2017-03-13 16:50:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743523003/60001
3 years, 9 months ago (2017-03-13 16:53:09 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 17:24:28 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5d5a66859c4e2a7b8f5b779f1525...

Powered by Google App Engine
This is Rietveld 408576698