Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2743483002: Revert of Move chrome/common/safe_browsing/csd.proto to components/safe_browsing (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, blundell+watchlist_chromium.org, droger+watchlist_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, oshima+watch_chromium.org, mac-reviews_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move chrome/common/safe_browsing/csd.proto to components/safe_browsing (patchset #2 id:20001 of https://codereview.chromium.org/2733343002/ ) Reason for revert: revert this CL since it broke linux bots. Original issue's description: > Move chrome/common/safe_browsing/csd.proto to components/safe_browsing > > Move csd.proto to components/safe_browsing. > This CL serves 2 purpose: > (1) moving csd.proto to component enables further componentization of > safe browsing reporting functionality, that will be used by WebView > (2) It also allows PasswordProtectionService, and PasswordManager code > to use these proto directly. > > BUG=698899, 688629 > > Review-Url: https://codereview.chromium.org/2733343002 > Cr-Commit-Position: refs/heads/master@{#455609} > Committed: https://chromium.googlesource.com/chromium/src/+/f3aafdc5ac1a6caf52c6c41615118e381ad9e549 TBR=nparker@chromium.org,vakh@chromium.org,sky@chromium.org,pkasting@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698899, 688629 Review-Url: https://codereview.chromium.org/2743483002 Cr-Commit-Position: refs/heads/master@{#455617} Committed: https://chromium.googlesource.com/chromium/src/+/7fdf43c8251e77df8fba1933f71b9a40b924359e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1096 lines, -1115 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_model_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_model_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_feedback.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/notification_image_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/notification_image_reporter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/signature_evaluator_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/threat_details.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/threat_details_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/threat_details_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/safe_browsing/csd.proto View 1 chunk +1019 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/download_protection_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/zip_analyzer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/zip_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/safe_browsing/zip_analyzer_results.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/tools/safe_browsing/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/tools/safe_browsing/sb_sigutil.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/safe_browsing/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D chrome/utility/safe_browsing/mac/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/utility/safe_browsing/mac/dmg_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M components/safe_browsing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/safe_browsing/csd.proto View 1 chunk +0 lines, -1016 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jialiu Lin
Created Revert of Move chrome/common/safe_browsing/csd.proto to components/safe_browsing
3 years, 9 months ago (2017-03-09 00:55:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743483002/1
3 years, 9 months ago (2017-03-09 00:55:48 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 00:59:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fdf43c8251e77df8fba1933f71b...

Powered by Google App Engine
This is Rietveld 408576698