Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2743463002: WIP: Pref service user prefs. (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP: Pref service user prefs. BUG=654988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1599 lines, -295 lines) Patch
M chrome/browser/browser_process_impl.cc View 6 chunks +38 lines, -4 lines 0 comments Download
M chrome/browser/prefs/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 5 chunks +112 lines, -149 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.h View 5 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.cc View 7 chunks +90 lines, -8 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 15 chunks +78 lines, -27 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/sync_preferences/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/user_prefs/tracked/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/user_prefs/tracked/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs/tracked/mock_validation_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter.h View 3 chunks +7 lines, -17 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter_unittest.cc View 20 chunks +65 lines, -68 lines 0 comments Download
M components/user_prefs/tracked/tracked_preference_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/sync_call_restrictions.h View 2 chunks +6 lines, -0 lines 0 comments Download
M services/preferences/BUILD.gn View 1 chunk +30 lines, -0 lines 0 comments Download
A services/preferences/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M services/preferences/manifest.json View 1 chunk +2 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
A services/preferences/public/cpp/persistent_pref_store_client.h View 1 chunk +94 lines, -0 lines 0 comments Download
A services/preferences/public/cpp/persistent_pref_store_client.cc View 1 chunk +187 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/pref_store_manager_impl.h View 4 chunks +30 lines, -1 line 0 comments Download
M services/preferences/public/cpp/pref_store_manager_impl.cc View 4 chunks +48 lines, -2 lines 0 comments Download
M services/preferences/public/cpp/preferences.typemap View 1 chunk +12 lines, -4 lines 0 comments Download
M services/preferences/public/cpp/preferences_struct_traits.h View 2 chunks +12 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/preferences_struct_traits.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/preferences/public/cpp/typemaps.gni View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 2 chunks +93 lines, -0 lines 0 comments Download
A services/preferences/user_prefs.h View 1 chunk +62 lines, -0 lines 0 comments Download
A services/preferences/user_prefs.cc View 1 chunk +160 lines, -0 lines 0 comments Download
A services/preferences/user_prefs_factory.h View 1 chunk +25 lines, -0 lines 0 comments Download
A services/preferences/user_prefs_factory.cc View 1 chunk +170 lines, -0 lines 0 comments Download
A services/preferences/user_prefs_unittest.cc View 1 chunk +145 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2740493002 Patch 120001

Powered by Google App Engine
This is Rietveld 408576698