| OLD | NEW |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef MOJO_PUBLIC_CPP_BINDINGS_SYNC_CALL_RESTRICTIONS_H_ | 5 #ifndef MOJO_PUBLIC_CPP_BINDINGS_SYNC_CALL_RESTRICTIONS_H_ |
| 6 #define MOJO_PUBLIC_CPP_BINDINGS_SYNC_CALL_RESTRICTIONS_H_ | 6 #define MOJO_PUBLIC_CPP_BINDINGS_SYNC_CALL_RESTRICTIONS_H_ |
| 7 | 7 |
| 8 #include "base/macros.h" | 8 #include "base/macros.h" |
| 9 #include "base/threading/thread_restrictions.h" | 9 #include "base/threading/thread_restrictions.h" |
| 10 #include "mojo/public/cpp/bindings/bindings_export.h" | 10 #include "mojo/public/cpp/bindings/bindings_export.h" |
| 11 | 11 |
| 12 #if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) | 12 #if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) |
| 13 #define ENABLE_SYNC_CALL_RESTRICTIONS 1 | 13 #define ENABLE_SYNC_CALL_RESTRICTIONS 1 |
| 14 #else | 14 #else |
| 15 #define ENABLE_SYNC_CALL_RESTRICTIONS 0 | 15 #define ENABLE_SYNC_CALL_RESTRICTIONS 0 |
| 16 #endif | 16 #endif |
| 17 | 17 |
| 18 namespace content { |
| 19 class BrowserMainRunnerImpl; |
| 20 } |
| 21 |
| 18 namespace leveldb { | 22 namespace leveldb { |
| 19 class LevelDBMojoProxy; | 23 class LevelDBMojoProxy; |
| 20 } | 24 } |
| 21 | 25 |
| 22 namespace ui { | 26 namespace ui { |
| 23 class Gpu; | 27 class Gpu; |
| 24 } | 28 } |
| 25 | 29 |
| 26 namespace views { | 30 namespace views { |
| 27 class ClipboardMus; | 31 class ClipboardMus; |
| (...skipping 23 matching lines...) Expand all Loading... |
| 51 // Inline the empty definitions of functions so that they can be compiled out. | 55 // Inline the empty definitions of functions so that they can be compiled out. |
| 52 static void AssertSyncCallAllowed() {} | 56 static void AssertSyncCallAllowed() {} |
| 53 #endif | 57 #endif |
| 54 | 58 |
| 55 private: | 59 private: |
| 56 // DO NOT ADD ANY OTHER FRIEND STATEMENTS, talk to mojo/OWNERS first. | 60 // DO NOT ADD ANY OTHER FRIEND STATEMENTS, talk to mojo/OWNERS first. |
| 57 // BEGIN ALLOWED USAGE. | 61 // BEGIN ALLOWED USAGE. |
| 58 friend class ui::Gpu; // http://crbug.com/620058 | 62 friend class ui::Gpu; // http://crbug.com/620058 |
| 59 // LevelDBMojoProxy makes same-process sync calls from the DB thread. | 63 // LevelDBMojoProxy makes same-process sync calls from the DB thread. |
| 60 friend class leveldb::LevelDBMojoProxy; | 64 friend class leveldb::LevelDBMojoProxy; |
| 65 // Sync calls are enabled before the main MessageLoop starts. |
| 66 friend class content::BrowserMainRunnerImpl; |
| 61 // END ALLOWED USAGE. | 67 // END ALLOWED USAGE. |
| 62 | 68 |
| 63 // BEGIN USAGE THAT NEEDS TO BE FIXED. | 69 // BEGIN USAGE THAT NEEDS TO BE FIXED. |
| 64 // In the non-mus case, we called blocking OS functions in the ui::Clipboard | 70 // In the non-mus case, we called blocking OS functions in the ui::Clipboard |
| 65 // implementation which weren't caught by sync call restrictions. Our blocking | 71 // implementation which weren't caught by sync call restrictions. Our blocking |
| 66 // calls to mus, however, are. | 72 // calls to mus, however, are. |
| 67 friend class views::ClipboardMus; | 73 friend class views::ClipboardMus; |
| 68 // END USAGE THAT NEEDS TO BE FIXED. | 74 // END USAGE THAT NEEDS TO BE FIXED. |
| 69 | 75 |
| 70 #if ENABLE_SYNC_CALL_RESTRICTIONS | 76 #if ENABLE_SYNC_CALL_RESTRICTIONS |
| (...skipping 21 matching lines...) Expand all Loading... |
| 92 | 98 |
| 93 DISALLOW_COPY_AND_ASSIGN(ScopedAllowSyncCall); | 99 DISALLOW_COPY_AND_ASSIGN(ScopedAllowSyncCall); |
| 94 }; | 100 }; |
| 95 | 101 |
| 96 DISALLOW_IMPLICIT_CONSTRUCTORS(SyncCallRestrictions); | 102 DISALLOW_IMPLICIT_CONSTRUCTORS(SyncCallRestrictions); |
| 97 }; | 103 }; |
| 98 | 104 |
| 99 } // namespace mojo | 105 } // namespace mojo |
| 100 | 106 |
| 101 #endif // MOJO_PUBLIC_CPP_BINDINGS_SYNC_CALL_RESTRICTIONS_H_ | 107 #endif // MOJO_PUBLIC_CPP_BINDINGS_SYNC_CALL_RESTRICTIONS_H_ |
| OLD | NEW |