Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 2743433002: Remove the Widevine signature files from the Linux and ChromeOS builds (Closed)

Created:
3 years, 9 months ago by jrummell
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, eme-reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Widevine signature files from the Linux and ChromeOS builds BUG=684878, 687320 Review-Url: https://codereview.chromium.org/2743433002 Cr-Commit-Position: refs/heads/master@{#456529} Committed: https://chromium.googlesource.com/chromium/src/+/d708846d788809f0cc8bbaae7794f5349844fe1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -29 lines) Patch
M chrome/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/linux/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/common/installer.include View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
jrummell
PTAL
3 years, 9 months ago (2017-03-08 21:30:26 UTC) #2
xhwang
Thanks! LGTM!
3 years, 9 months ago (2017-03-08 21:45:08 UTC) #3
jrummell
+mmoss@, dpranke@ for OWNERS review (this CL is simply removing stuff from the build)
3 years, 9 months ago (2017-03-08 21:48:56 UTC) #5
Michael Moss
On 2017/03/08 21:48:56, jrummell wrote: > +mmoss@, dpranke@ for OWNERS review (this CL is simply ...
3 years, 9 months ago (2017-03-08 21:55:04 UTC) #6
xhwang
On 2017/03/08 21:55:04, Michael Moss wrote: > On 2017/03/08 21:48:56, jrummell wrote: > > +mmoss@, ...
3 years, 9 months ago (2017-03-08 22:11:37 UTC) #7
jrummell
ping dpranke@ for OWNERS review
3 years, 9 months ago (2017-03-11 00:14:13 UTC) #8
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-13 21:29:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743433002/1
3 years, 9 months ago (2017-03-13 21:41:39 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:13:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d708846d788809f0cc8bbaae7794...

Powered by Google App Engine
This is Rietveld 408576698