Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2743373002: predictors: Highlight prefetchable resources in webui. (Closed)

Created:
3 years, 9 months ago by alexilin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Highlight prefetchable resources in webui. Makes Resource Prefetch Predictor table in webui easier for evaluation. BUG=631966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2743373002 Cr-Commit-Position: refs/heads/master@{#456737} Committed: https://chromium.googlesource.com/chromium/src/+/37e768daa8579acfc7e046c9decfaa75488b7847

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/predictors/predictors.css View 1 chunk +4 lines, -0 lines 1 comment Download
M chrome/browser/resources/predictors/resource_prefetch_predictor.js View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/predictors/predictors_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
alexilin
PTAL, thanks! https://codereview.chromium.org/2743373002/diff/1/chrome/browser/resources/predictors/predictors.css File chrome/browser/resources/predictors/predictors.css (right): https://codereview.chromium.org/2743373002/diff/1/chrome/browser/resources/predictors/predictors.css#newcode40 chrome/browser/resources/predictors/predictors.css:40: tr td:first-child[rowspan] { To not highlight a ...
3 years, 9 months ago (2017-03-13 15:14:41 UTC) #3
alexilin
It's time for gently ping.
3 years, 9 months ago (2017-03-14 14:26:12 UTC) #4
Benoit L
lgtm
3 years, 9 months ago (2017-03-14 14:39:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743373002/1
3 years, 9 months ago (2017-03-14 14:55:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/384929)
3 years, 9 months ago (2017-03-14 15:02:41 UTC) #9
alexilin
Bernhard, please review webui changes in chrome/browser/resources/predictors/* Thanks!
3 years, 9 months ago (2017-03-14 15:18:39 UTC) #11
Bernhard Bauer
Web UI LGTM.
3 years, 9 months ago (2017-03-14 16:44:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743373002/1
3 years, 9 months ago (2017-03-14 16:55:36 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 17:01:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37e768daa8579acfc7e046c9decf...

Powered by Google App Engine
This is Rietveld 408576698