Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2743363006: Clean up cc/paint interfaces (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
index 0df90d0a9753d32a449ab89e0a001078987f05ec..a3eab6f124eacef5475febdd25b0f29878ae959c 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
@@ -767,12 +767,15 @@ void PaintController::showUnderInvalidationError(
#ifndef NDEBUG
const PaintRecord* newRecord =
- newItem.isDrawing()
- ? static_cast<const DrawingDisplayItem&>(newItem).GetPaintRecord()
- : nullptr;
+ newItem.isDrawing() ? static_cast<const DrawingDisplayItem&>(newItem)
danakj 2017/03/16 20:06:17 maybe a ternary isnt the ring thing here and just
+ .GetPaintRecord()
+ .get()
+ : nullptr;
const PaintRecord* oldRecord =
danakj 2017/03/16 20:06:17 same
oldItem && oldItem->isDrawing()
- ? static_cast<const DrawingDisplayItem*>(oldItem)->GetPaintRecord()
+ ? static_cast<const DrawingDisplayItem*>(oldItem)
+ ->GetPaintRecord()
+ .get()
: nullptr;
LOG(INFO) << "new record:\n"
<< (newRecord ? recordAsDebugString(newRecord) : "None");

Powered by Google App Engine
This is Rietveld 408576698