third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp - Issue 2743363006: Clean up cc/paint interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

Issue 2743363006: Clean up cc/paint interfaces (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h » ('j') | third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

index 4553f3dc5f0c406a1be30e5091c6a15b91c9f9f3..188549239cf450cb1e73302a74b1e6ad471ea71e 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

@@ -93,7 +93,8 @@ std::unique_ptr<JSONArray> DisplayItemList::subsequenceAsJSON(

if ((options & ShowPaintRecords) && displayItem.isDrawing()) {

if (const PaintRecord* record =

static_cast<const DrawingDisplayItem&>(displayItem)

danakj 2017/03/16 20:06:16 a temp var here could go a long way to less wild l

- .GetPaintRecord()) {

+ .GetPaintRecord()

+ .get()) {

json->setString("record", recordAsDebugString(record));

}