Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp

Issue 2743363006: Clean up cc/paint interfaces (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp
index b67fad7ff0dd84e6754f9dea1ba054282a7113fb..ce6643543799f85d52c8462adf78a845438c72ef 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp
@@ -82,7 +82,7 @@ TEST(GraphicsContextTest, Recording) {
context.beginRecording(bounds);
context.fillRect(FloatRect(0, 0, 50, 50), opaque, SkBlendMode::kSrcOver);
sk_sp<const PaintRecord> record = context.endRecording();
- canvas.drawPicture(record.get());
+ canvas.drawPicture(record);
danakj 2017/03/16 20:06:16 move() or pass endRecording() directly. the variab
EXPECT_OPAQUE_PIXELS_ONLY_IN_RECT(bitmap, IntRect(0, 0, 50, 50))
context.beginRecording(bounds);
@@ -92,7 +92,7 @@ TEST(GraphicsContextTest, Recording) {
// recording.
EXPECT_OPAQUE_PIXELS_ONLY_IN_RECT(bitmap, IntRect(0, 0, 50, 50))
- canvas.drawPicture(record.get());
+ canvas.drawPicture(record);
danakj 2017/03/16 20:06:16 same
EXPECT_OPAQUE_PIXELS_ONLY_IN_RECT(bitmap, IntRect(0, 0, 100, 100))
}
@@ -125,7 +125,7 @@ TEST(GraphicsContextTest, UnboundedDrawsAreClipped) {
// Make the device opaque in 10,10 40x40.
context.fillRect(FloatRect(10, 10, 40, 40), opaque, SkBlendMode::kSrcOver);
sk_sp<const PaintRecord> record = context.endRecording();
- canvas.drawPicture(record.get());
+ canvas.drawPicture(record);
danakj 2017/03/16 20:06:16 same
EXPECT_OPAQUE_PIXELS_ONLY_IN_RECT(bitmap, IntRect(10, 10, 40, 40));
context.beginRecording(bounds);
@@ -143,7 +143,7 @@ TEST(GraphicsContextTest, UnboundedDrawsAreClipped) {
context.drawPath(path.getSkPath(), flags);
record = context.endRecording();
- canvas.drawPicture(record.get());
+ canvas.drawPicture(record);
danakj 2017/03/16 20:06:16 same same
EXPECT_OPAQUE_PIXELS_IN_RECT(bitmap, IntRect(20, 10, 30, 40));
}

Powered by Google App Engine
This is Rietveld 408576698