third_party/WebKit/Source/core/paint/ClipPathClipper.cpp - Issue 2743363006: Clean up cc/paint interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ClipPathClipper.cpp

Issue 2743363006: Clean up cc/paint interfaces (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/ClipPathClipper.cpp

diff --git a/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp b/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp

index 58bb12919ff0b5f86c303e23960faae416fd0dcd..067859fa8c2ab450d60c092d8060899aa8cb47aa 100644

--- a/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp

+++ b/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp

@@ -212,7 +212,7 @@ bool ClipPathClipper::drawClipAsMask(const FloatRect& targetBoundingBox,

LayoutObjectDrawingRecorder drawingRecorder(

m_context, m_layoutObject, DisplayItem::kSVGClip, targetVisualRect);

sk_sp<PaintRecord> maskPaintRecord = maskBuilder.endRecording();

- m_context.drawRecord(maskPaintRecord.get());

+ m_context.drawRecord(maskPaintRecord);

danakj 2017/03/16 20:06:15 move(), or just pass endRecording() directly

return true;

}