Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp

Issue 2743363006: Clean up cc/paint interfaces (Closed)
Patch Set: Fix PaintControllerTest v2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/paint/PaintArtifact.h" 5 #include "platform/graphics/paint/PaintArtifact.h"
6 6
7 #include "platform/geometry/IntRect.h" 7 #include "platform/geometry/IntRect.h"
8 #include "platform/graphics/GraphicsLayer.h" 8 #include "platform/graphics/GraphicsLayer.h"
9 #include "platform/graphics/paint/DrawingDisplayItem.h" 9 #include "platform/graphics/paint/DrawingDisplayItem.h"
10 #include "platform/instrumentation/tracing/TraceEvent.h" 10 #include "platform/instrumentation/tracing/TraceEvent.h"
11 #include "public/platform/WebDisplayItemList.h" 11 #include "public/platform/WebDisplayItemList.h"
12 #include "third_party/skia/include/core/SkRegion.h" 12 #include "third_party/skia/include/core/SkRegion.h"
13 13
14 namespace blink { 14 namespace blink {
15 15
16 namespace { 16 namespace {
17 17
18 void computeChunkBoundsAndOpaqueness(const DisplayItemList& displayItems, 18 void computeChunkBoundsAndOpaqueness(const DisplayItemList& displayItems,
19 Vector<PaintChunk>& paintChunks) { 19 Vector<PaintChunk>& paintChunks) {
20 for (PaintChunk& chunk : paintChunks) { 20 for (PaintChunk& chunk : paintChunks) {
21 FloatRect bounds; 21 FloatRect bounds;
22 SkRegion knownToBeOpaqueRegion; 22 SkRegion knownToBeOpaqueRegion;
23 for (const DisplayItem& item : displayItems.itemsInPaintChunk(chunk)) { 23 for (const DisplayItem& item : displayItems.itemsInPaintChunk(chunk)) {
24 bounds.unite(FloatRect(item.client().visualRect())); 24 bounds.unite(FloatRect(item.client().visualRect()));
25 if (!item.isDrawing()) 25 if (!item.isDrawing())
26 continue; 26 continue;
27 const auto& drawing = static_cast<const DrawingDisplayItem&>(item); 27 const auto& drawing = static_cast<const DrawingDisplayItem&>(item);
28 if (const PaintRecord* record = drawing.GetPaintRecord()) { 28 if (const PaintRecord* record = drawing.GetPaintRecord().get()) {
29 if (drawing.knownToBeOpaque()) { 29 if (drawing.knownToBeOpaque()) {
30 // TODO(pdr): It may be too conservative to round in to the 30 // TODO(pdr): It may be too conservative to round in to the
31 // enclosedIntRect. 31 // enclosedIntRect.
32 SkIRect conservativeRoundedRect; 32 SkIRect conservativeRoundedRect;
33 const SkRect& cullRect = record->cullRect(); 33 const SkRect& cullRect = record->cullRect();
34 cullRect.roundIn(&conservativeRoundedRect); 34 cullRect.roundIn(&conservativeRoundedRect);
35 knownToBeOpaqueRegion.op(conservativeRoundedRect, 35 knownToBeOpaqueRegion.op(conservativeRoundedRect,
36 SkRegion::kUnion_Op); 36 SkRegion::kUnion_Op);
37 } 37 }
38 } 38 }
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 size_t visualRectIndex = 0; 93 size_t visualRectIndex = 0;
94 for (const DisplayItem& displayItem : m_displayItemList) { 94 for (const DisplayItem& displayItem : m_displayItemList) {
95 displayItem.appendToWebDisplayItemList( 95 displayItem.appendToWebDisplayItemList(
96 m_displayItemList.visualRect(visualRectIndex), list); 96 m_displayItemList.visualRect(visualRectIndex), list);
97 visualRectIndex++; 97 visualRectIndex++;
98 } 98 }
99 list->setIsSuitableForGpuRasterization(isSuitableForGpuRasterization()); 99 list->setIsSuitableForGpuRasterization(isSuitableForGpuRasterization());
100 } 100 }
101 101
102 } // namespace blink 102 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698