Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2743353002:
Roll src/third_party/libsrtp/ 0e0936f30..d15364a80 (1 commit) (Closed)
DescriptionRoll src/third_party/libsrtp/ 0e0936f30..d15364a80 (1 commit)
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/0e0936f3013f..d15364a801e4
$ git log 0e0936f30..d15364a80 --date=short --no-merges --format='%ad %ae %s'
2017-03-13 kjellander Fix incorrectly masked seq number for GCM IV.
Created with:
roll-dep src/third_party/libsrtp
BUG=webrtc:7288
Review-Url: https://codereview.chromium.org/2743353002
Cr-Commit-Position: refs/heads/master@{#457171}
Committed: https://chromium.googlesource.com/chromium/src/+/57f0024708538f6cf18f2054e9bb612510059250
Patch Set 1 #Messages
Total messages: 24 (11 generated)
jbauch@webrtc.org changed reviewers: + pthatcher@chromium.org
Now that this will soon land in WebRTC, could you please write the PSA as commented in the original CL introducing the change? https://codereview.webrtc.org/2723863003/#msg11
The CQ bit was checked by pthatcher@webrtc.org
The CQ bit was unchecked by pthatcher@webrtc.org
lgtm On 2017/03/13 13:55:31, joachim wrote: > Now that this will soon land in WebRTC, could you please write the PSA as > commented in the original CL introducing the change? > > https://codereview.webrtc.org/2723863003/#msg11
The CQ bit was checked by pthatcher@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/03/14 22:57:41, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Should I add somebody else or can you do the review with your chromium account (if that is a committer)?
lgtm Trying from my Chromium account, but I'm not a Chromium committer, so it may not work.
The CQ bit was checked by pthatcher@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/03/15 15:40:04, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Nope :)
jbauch@webrtc.org changed reviewers: + kjellander@chromium.org
kjellander@ this rolls the libsrtp change you recently landed. Are you a committer here and could review this? Thanks. The PSA from Peter is online here: https://groups.google.com/forum/#!topic/discuss-webrtc/Nj5IZuUNNj4
The CQ bit was checked by kjellander@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489602401703440, "parent_rev":
"a4c32ce963c3ff25beb2edbd857f8906c22ad6ac", "commit_rev":
"57f0024708538f6cf18f2054e9bb612510059250"}
Message was sent while issue was closed.
Description was changed from ========== Roll src/third_party/libsrtp/ 0e0936f30..d15364a80 (1 commit) https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/0e0936f3013f... $ git log 0e0936f30..d15364a80 --date=short --no-merges --format='%ad %ae %s' 2017-03-13 kjellander Fix incorrectly masked seq number for GCM IV. Created with: roll-dep src/third_party/libsrtp BUG=webrtc:7288 ========== to ========== Roll src/third_party/libsrtp/ 0e0936f30..d15364a80 (1 commit) https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/0e0936f3013f... $ git log 0e0936f30..d15364a80 --date=short --no-merges --format='%ad %ae %s' 2017-03-13 kjellander Fix incorrectly masked seq number for GCM IV. Created with: roll-dep src/third_party/libsrtp BUG=webrtc:7288 Review-Url: https://codereview.chromium.org/2743353002 Cr-Commit-Position: refs/heads/master@{#457171} Committed: https://chromium.googlesource.com/chromium/src/+/57f0024708538f6cf18f2054e9bb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/57f0024708538f6cf18f2054e9bb... |
