Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2743323004: Revert of [libfuzzer] proto-based renderer fuzzer draft (Closed)

Created:
3 years, 9 months ago by aizatsky
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, fuzzing_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [libfuzzer] proto-based renderer fuzzer draft (patchset #1 id:1 of https://codereview.chromium.org/2744403002/ ) Reason for revert: proto2 has the same problem: 13882/56507] CXX obj/content/test/fuzzer/html_tree_proto/html_tree.pb.obj FAILED: obj/content/test/fuzzer/html_tree_proto/html_tree.pb.obj ninja -t msvc -e environment.x86 -- C:\b\c\goma_client/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/content/test/fuzzer/html_tree_proto/html_tree.pb.obj.rsp /c gen/content/test/fuzzer/html_tree.pb.cc /Foobj/content/test/fuzzer/html_tree_proto/html_tree.pb.obj /Fd"obj/content/test/fuzzer/html_tree_proto_cc.pdb" c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(171): error C2220: warning treated as error - no 'object' file generated c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(171): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(172): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(173): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(185): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(186): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(187): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(188): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(201): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(202): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(222): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(223): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(224): warning C4125: decimal digit terminates octal escape sequence c:\b\c\b\win_archive\src\out\release\gen\content\test\fuzzer\html_tree.pb.cc(225): warning C4125: decimal digit terminates octal escape sequence Original issue's description: > [libfuzzer] proto-based renderer fuzzer draft > > This reverts commit 42ada11652ece20e9e564ab45552985ab9fa6308. > Difference: proto2 instead of proto3 > > BUG= > > Review-Url: https://codereview.chromium.org/2744403002 > Cr-Commit-Position: refs/heads/master@{#456497} > Committed: https://chromium.googlesource.com/chromium/src/+/41fd546edd6cb8dca649b193fad39c4a86547850 TBR=vitalybuka@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2743323004 Cr-Commit-Position: refs/heads/master@{#456507} Committed: https://chromium.googlesource.com/chromium/src/+/8bcc0b7a1ed6f4cbdf8d6d1dd203734390f010e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -419 lines) Patch
M content/test/fuzzer/BUILD.gn View 2 chunks +0 lines, -19 lines 0 comments Download
D content/test/fuzzer/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/test/fuzzer/html_tree.proto View 1 chunk +0 lines, -252 lines 0 comments Download
D content/test/fuzzer/renderer_proto_tree_fuzzer.cc View 1 chunk +0 lines, -144 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
aizatsky
Created Revert of [libfuzzer] proto-based renderer fuzzer draft
3 years, 9 months ago (2017-03-13 22:33:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743323004/1
3 years, 9 months ago (2017-03-13 22:34:07 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 22:36:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bcc0b7a1ed6f4cbdf8d6d1dd203...

Powered by Google App Engine
This is Rietveld 408576698