Disable Normal DCHECK

Disable Normal DCHECK

This DCHECK fires for some seemingly irrelevant polygons.
The rendering now proceeds quite well when it is removed.
It is symptomatic of calculcations getting unstable, which
can be handled later in the pruning.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2743283003
Cr-Commit-Position: refs/heads/master@{#457823}
Committed: https://chromium.googlesource.com/chromium/src/+/bba421837cf80e6b786c736235f9ec10fa931302

[Peter Mayo, 2017-03-17 00:42:55]

petermayo@chromium.org changed reviewers:
+ danakj@chromium.org

[Peter Mayo, 2017-03-17 00:42:55]

As discussed offline, reworded.  PTaL.

[danakj, 2017-03-17 14:14:44]

LGTM

https://codereview.chromium.org/2743283003/diff/20001/cc/quads/draw_polygon.cc
File cc/quads/draw_polygon.cc (right):

https://codereview.chromium.org/2743283003/diff/20001/cc/quads/draw_polygon.c...
cc/quads/draw_polygon.cc:46: normal_ = normal;
can this be initialized in the constructor init list (like "normal_(normal)")
above then?

[Peter Mayo, 2017-03-17 16:04:07]

PTaL

https://codereview.chromium.org/2743283003/diff/20001/cc/quads/draw_polygon.cc
File cc/quads/draw_polygon.cc (right):

https://codereview.chromium.org/2743283003/diff/20001/cc/quads/draw_polygon.c...
cc/quads/draw_polygon.cc:46: normal_ = normal;
On 2017/03/17 14:14:44, danakj wrote:
> can this be initialized in the constructor init list (like "normal_(normal)")
> above then?

Yes, that makes sense now.  Done.

[danakj, 2017-03-17 16:13:35]

LGTM

[Peter Mayo, 2017-03-17 17:18:25]

The CQ bit was checked by petermayo@chromium.org

[commit-bot: I haz the power, 2017-03-17 17:18:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:29:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489771105900790,
"parent_rev": "4c4039993456e1b2a0f861aaa56a947092e5e4b3", "commit_rev":
"bba421837cf80e6b786c736235f9ec10fa931302"}

[commit-bot: I haz the power, 2017-03-17 18:30:35]

Description was changed from

==========
Disable Normal DCHECK

This DCHECK fires for some seemingly irrelevant polygons.
The rendering now proceeds quite well when it is removed.
It is symptomatic of calculcations getting unstable, which
can be handled later in the pruning.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Disable Normal DCHECK

This DCHECK fires for some seemingly irrelevant polygons.
The rendering now proceeds quite well when it is removed.
It is symptomatic of calculcations getting unstable, which
can be handled later in the pruning.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2743283003
Cr-Commit-Position: refs/heads/master@{#457823}
Committed:
https://chromium.googlesource.com/chromium/src/+/bba421837cf80e6b786c736235f9...
==========

[commit-bot: I haz the power, 2017-03-17 18:30:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bba421837cf80e6b786c736235f9...