Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2743273002: [Doodle] Don't create invalid DoodleImages or DoodleConfigs (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
Reviewers:
fhorschig, sfiera
CC:
chromium-reviews, fhorschig
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Doodle] Don't create invalid DoodleImages or DoodleConfigs Follow-up to https://codereview.chromium.org/2740013005/ BUG=690467 Review-Url: https://codereview.chromium.org/2743273002 Cr-Commit-Position: refs/heads/master@{#456351} Committed: https://chromium.googlesource.com/chromium/src/+/e7ab62c50eabd5a4d1662d641ba92431023900a6

Patch Set 1 #

Total comments: 2

Patch Set 2 : add checks for absence of optional images #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M components/doodle/doodle_fetcher_impl_unittest.cc View 1 3 chunks +20 lines, -15 lines 0 comments Download
M components/doodle/doodle_service_unittest.cc View 11 chunks +14 lines, -20 lines 0 comments Download
M components/doodle/doodle_types.h View 3 chunks +5 lines, -6 lines 0 comments Download
M components/doodle/doodle_types.cc View 5 chunks +14 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
Marc Treib
sfiera: PTAL! fhorschig: FYI
3 years, 9 months ago (2017-03-13 10:22:33 UTC) #4
sfiera
https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fetcher_impl_unittest.cc File components/doodle/doodle_fetcher_impl_unittest.cc (right): https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fetcher_impl_unittest.cc#newcode359 components/doodle/doodle_fetcher_impl_unittest.cc:359: ASSERT_TRUE(config.transparent_large_image.has_value()); Shouldn't there be some tests in this file ...
3 years, 9 months ago (2017-03-13 10:29:49 UTC) #5
Marc Treib
https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fetcher_impl_unittest.cc File components/doodle/doodle_fetcher_impl_unittest.cc (right): https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fetcher_impl_unittest.cc#newcode359 components/doodle/doodle_fetcher_impl_unittest.cc:359: ASSERT_TRUE(config.transparent_large_image.has_value()); On 2017/03/13 10:29:49, sfiera wrote: > Shouldn't there ...
3 years, 9 months ago (2017-03-13 10:50:33 UTC) #6
sfiera
LGTM
3 years, 9 months ago (2017-03-13 10:52:08 UTC) #9
fhorschig
Drive-by LGTM and thanks!
3 years, 9 months ago (2017-03-13 10:54:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743273002/20001
3 years, 9 months ago (2017-03-13 11:00:32 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 11:22:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7ab62c50eabd5a4d1662d641ba9...

Powered by Google App Engine
This is Rietveld 408576698