[Doodle] Don't create invalid DoodleImages or DoodleConfigs

[Doodle] Don't create invalid DoodleImages or DoodleConfigs

Follow-up to https://codereview.chromium.org/2740013005/

BUG=690467
Review-Url: https://codereview.chromium.org/2743273002
Cr-Commit-Position: refs/heads/master@{#456351}
Committed: https://chromium.googlesource.com/chromium/src/+/e7ab62c50eabd5a4d1662d641ba92431023900a6

[Marc Treib, 2017-03-13 10:22:05]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 10:22:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-03-13 10:22:32]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-03-13 10:22:33]

sfiera: PTAL!

fhorschig: FYI

[sfiera, 2017-03-13 10:29:49]

https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fe...
File components/doodle/doodle_fetcher_impl_unittest.cc (right):

https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fe...
components/doodle/doodle_fetcher_impl_unittest.cc:359:
ASSERT_TRUE(config.transparent_large_image.has_value());
Shouldn't there be some tests in this file that deal with
!config.transparent_large_image.has_value()?

[Marc Treib, 2017-03-13 10:50:33]

https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fe...
File components/doodle/doodle_fetcher_impl_unittest.cc (right):

https://codereview.chromium.org/2743273002/diff/1/components/doodle/doodle_fe...
components/doodle/doodle_fetcher_impl_unittest.cc:359:
ASSERT_TRUE(config.transparent_large_image.has_value());
On 2017/03/13 10:29:49, sfiera wrote:
> Shouldn't there be some tests in this file that deal with
> !config.transparent_large_image.has_value()?

I'd argue that most of this doesn't really belong here in the first place :) 
That said, there are some tests above that don't set the optional image fields,
but they don't check their absence either. I've added some checks there.

Also, I have another follow-up almost ready that adds dedicated tests for the
parsing.

[Marc Treib, 2017-03-13 10:50:39]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 10:50:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2017-03-13 10:52:08]

LGTM

[fhorschig, 2017-03-13 10:54:52]

fhorschig@chromium.org changed reviewers:
+ fhorschig@chromium.org

[fhorschig, 2017-03-13 10:54:53]

Drive-by LGTM and thanks!

[Marc Treib, 2017-03-13 11:00:24]

The CQ bit was unchecked by treib@chromium.org

[Marc Treib, 2017-03-13 11:00:25]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-03-13 11:00:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 11:21:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489402825341220,
"parent_rev": "69c3a1dcf2c50b08b5d1970900da160809e7d6a5", "commit_rev":
"e7ab62c50eabd5a4d1662d641ba92431023900a6"}

[commit-bot: I haz the power, 2017-03-13 11:22:24]

Description was changed from

==========
[Doodle] Don't create invalid DoodleImages or DoodleConfigs

Follow-up to https://codereview.chromium.org/2740013005/

BUG=690467
==========

to

==========
[Doodle] Don't create invalid DoodleImages or DoodleConfigs

Follow-up to https://codereview.chromium.org/2740013005/

BUG=690467

Review-Url: https://codereview.chromium.org/2743273002
Cr-Commit-Position: refs/heads/master@{#456351}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7ab62c50eabd5a4d1662d641ba9...
==========

[commit-bot: I haz the power, 2017-03-13 11:22:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7ab62c50eabd5a4d1662d641ba9...