Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2743253009: Add a partial load test for an animated PNG image (Closed)

Created:
3 years, 9 months ago by Noel Gordon
Modified:
3 years, 9 months ago
Reviewers:
scroggo_chromium
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a partial load test for an animated PNG image Use HTTP test load-and-stall script to partially load the initial frame of a animated PNG image. Render the image over CSS background color green and confirm that the CSS color appears in the undecoded regions of the image. BUG=700892 Review-Url: https://codereview.chromium.org/2743253009 Cr-Commit-Position: refs/heads/master@{#457569} Committed: https://chromium.googlesource.com/chromium/src/+/2ef26ee13e1d61e0d52daf64bd4ad2ef7a7907d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/images/png-animated-partial-load.html View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Noel Gordon
PTAL, if the patch looks good and passes the bots, go ahead and commit it.
3 years, 9 months ago (2017-03-16 14:53:09 UTC) #5
scroggo_chromium
lgtm
3 years, 9 months ago (2017-03-16 15:04:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743253009/1
3 years, 9 months ago (2017-03-16 21:35:51 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 21:45:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ef26ee13e1d61e0d52daf64bd4a...

Powered by Google App Engine
This is Rietveld 408576698