Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2743253002: [turbofan] Skip JSCallReducer and JSNativeContextSpecialization on asm.js. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Skip JSCallReducer and JSNativeContextSpecialization on asm.js. For the old asm.js pipeline, there's no point in running either the JSCallReducer or the JSNativeContextSpecialization, as both will not kick in for any asm.js relevant code. So remove the kDeoptimizationEnabled flag from both of them and just run them on regular JavaScript only. Drive-by-fix: Slightly rearrange keyed access to String receivers in the JSNativeContextSpecialization::ReduceKeyedAccess method to access constant characters independent of the IC mode (as long as the constant index is within the range of the receiver). BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2743253002 Cr-Commit-Position: refs/heads/master@{#43813} Committed: https://chromium.googlesource.com/v8/v8/+/94b33165ce662a7596b3f599a62091a554faa83c

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -99 lines) Patch
M src/compiler/js-call-reducer.h View 3 chunks +1 line, -13 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 12 chunks +39 lines, -68 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-13 06:23:21 UTC) #1
Jarin
lgtm
3 years, 9 months ago (2017-03-15 08:34:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743253002/20001
3 years, 9 months ago (2017-03-15 08:37:36 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 09:06:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/94b33165ce662a7596b3f599a62091a554f...

Powered by Google App Engine
This is Rietveld 408576698