Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 2743243004: Automatically dispatch "services" endpoint. (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Automatically dispatch "services" endpoint. Currently, LogDog requires users to manually specicify that "/prpc/logdog.Services/..." pRPC calls get dispatched to the services endpoint as an optimization. Fix this, so that the optimization is no longer necessary and that all such calls automatically get dispatched to the services endpoint. BUG=chromium:700934 TEST=None R=hinoka@chromium.org, iannucci@chromium.org Review-Url: https://codereview.chromium.org/2743243004 Committed: https://github.com/luci/luci-go/commit/918f7ea1301278c62d3dcc5af775f60ff5faf7c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M logdog/appengine/cmd/coordinator/services/module.cfg View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
3 years, 9 months ago (2017-03-13 23:31:10 UTC) #1
hinoka
lgtm
3 years, 9 months ago (2017-03-13 23:32:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743243004/1
3 years, 9 months ago (2017-03-13 23:33:48 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:39:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/918f7ea1301278c62d3dcc5af775f60ff5faf7c2

Powered by Google App Engine
This is Rietveld 408576698