Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2743223003: Mark sub-frame root layer non-fast scrollable when wheel handlers present. (Closed)

Created:
3 years, 9 months ago by wjmaclean
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Mark sub-frame root layer non-fast scrollable when wheel handlers present. Just like with touch event handlers, at present a sub-frame's compositor does not receive regions rects for non-fast scrollable regions that accompany MouseWheel handlers. Until ScrollingCoordinator is made per-frame, we should mark the entire root layer rect as non-fast scrollable in the presence of blocking wheel handlers. The primary changes are all in render_widget_compositor.cc; other files are touched only to give the function a more inclusive name. BUG=698195 Review-Url: https://codereview.chromium.org/2740133002 Cr-Commit-Position: refs/heads/master@{#456131} (cherry picked from commit 47b1b819e0e239b1c753ae4e736f77ac9ccafcdd) Review-Url: https://codereview.chromium.org/2743223003 . Cr-Commit-Position: refs/branch-heads/3029@{#146} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e4c4f772242dae97a0503437a4001b5b22a357a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -15 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 chunk +148 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +14 lines, -3 lines 0 comments Download
A content/test/data/page_with_scrollable_div.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
3 years, 9 months ago (2017-03-13 13:57:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4c4f772242dae97a0503437a4001b5b22a357a7.

Powered by Google App Engine
This is Rietveld 408576698