Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2743183003: [turbofan] Fix lowering of Number.isNaN(). (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix lowering of Number.isNaN(). BUG=v8:6082 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2743183003 Cr-Commit-Position: refs/heads/master@{#43735} Committed: https://chromium.googlesource.com/v8/v8/+/9bee8f1065da5172fa9b1746d7658a90873e47c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-6082.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-13 06:41:35 UTC) #1
Yang
On 2017/03/13 06:41:35, Benedikt Meurer wrote: lgtm
3 years, 9 months ago (2017-03-13 06:42:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743183003/1
3 years, 9 months ago (2017-03-13 06:46:04 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 07:01:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9bee8f1065da5172fa9b1746d7658a90873...

Powered by Google App Engine
This is Rietveld 408576698