[inspector] use same schedulePauseOnNextStatement strategy for Debugger.pause

[inspector] use same schedulePauseOnNextStatement strategy for Debugger.pause

+ added a test.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2743163002
Cr-Commit-Position: refs/heads/master@{#44082}
Committed: https://chromium.googlesource.com/v8/v8/+/249001b4e9a59ff52fc1f9d9a3e89846a7fc19a1

[kozy, 2017-03-12 03:26:32]

Dmitry, please take a look.

[dgozman, 2017-03-13 18:10:52]

lgtm

https://codereview.chromium.org/2743163002/diff/1/src/inspector/v8-debugger-a...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2743163002/diff/1/src/inspector/v8-debugger-a...
src/inspector/v8-debugger-agent-impl.cc:290:
m_debugger->setBreakpointsActivated(active);
clearBreakDetails();

And test it :-)

[kozy, 2017-03-24 01:53:05]

all done, thanks!

https://codereview.chromium.org/2743163002/diff/1/src/inspector/v8-debugger-a...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2743163002/diff/1/src/inspector/v8-debugger-a...
src/inspector/v8-debugger-agent-impl.cc:290:
m_debugger->setBreakpointsActivated(active);
On 2017/03/13 18:10:52, dgozman wrote:
> clearBreakDetails();
> 
> And test it :-)

Done.

[kozy, 2017-03-24 01:53:09]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-24 01:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2743163002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-24 01:53:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 02:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 02:12:34]

Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/24878)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[kozy, 2017-03-24 02:22:17]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-24 02:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2743163002/#ps40001
(title: "better test")

[commit-bot: I haz the power, 2017-03-24 02:22:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 02:44:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490322137969330,
"parent_rev": "2629f811ea2f784e810ea9a38c1d290097cfa8e3", "commit_rev":
"249001b4e9a59ff52fc1f9d9a3e89846a7fc19a1"}

[commit-bot: I haz the power, 2017-03-24 02:44:32]

Description was changed from

==========
[inspector] use same schedulePauseOnNextStatement strategy for Debugger.pause

+ added a test.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[inspector] use same schedulePauseOnNextStatement strategy for Debugger.pause

+ added a test.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2743163002
Cr-Commit-Position: refs/heads/master@{#44082}
Committed:
https://chromium.googlesource.com/v8/v8/+/249001b4e9a59ff52fc1f9d9a3e89846a7f...
==========

[commit-bot: I haz the power, 2017-03-24 02:44:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/249001b4e9a59ff52fc1f9d9a3e89846a7f...