MD Settings: use the subLabel of <settings-toggle-button>s for the aria

MD Settings: use the subLabel of <settings-toggle-button>s for the aria
description when the <paper-toggle-button> is focused

R=hcarmona@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2743063004
Cr-Commit-Position: refs/heads/master@{#456254}
Committed: https://chromium.googlesource.com/chromium/src/+/eaeb5c6fe84d2ae813eef86e44a85b767c53b612

[Dan Beam, 2017-03-10 22:25:11]

Description was changed from

==========
MD Settings: use the subLabel of <settings-toggle-button>s for the aria
description when the <paper-toggle-button> is focused

R=hcarmona@chromium.org
BUG=none
==========

to

==========
MD Settings: use the subLabel of <settings-toggle-button>s for the aria
description when the <paper-toggle-button> is focused

R=hcarmona@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-10 22:25:28]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 22:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2017-03-10 22:26:41]

lgtm

[Dan Beam, 2017-03-10 22:40:31]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-03-10 22:40:34]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-10 22:40:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 23:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 23:29:38]

Failed to apply patch for
chrome/browser/resources/settings/controls/settings_toggle_button.html:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/settings/controls/settings_toggle_button.html:41
  error: chrome/browser/resources/settings/controls/settings_toggle_button.html:
patch does not apply

Patch:      
chrome/browser/resources/settings/controls/settings_toggle_button.html
Index: chrome/browser/resources/settings/controls/settings_toggle_button.html
diff --git
a/chrome/browser/resources/settings/controls/settings_toggle_button.html
b/chrome/browser/resources/settings/controls/settings_toggle_button.html
index
b4bc473a2588da1f30b11b510e1c98a33abef222..a44a0890ef99c37041ca4fe349fa87b853f8a258
100644
--- a/chrome/browser/resources/settings/controls/settings_toggle_button.html
+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.html
@@ -41,7 +41,7 @@
       <div class="flex" on-tap="onLabelWrapperTap_"
           actionable$="[[!controlDisabled_(disabled, pref.*)]]">
         <div id="label" class="label">[[label]]</div>
-        <div class="secondary label">[[subLabel]]</div>
+        <div id="subLabel" class="secondary label">[[subLabel]]</div>
       </div>
       <content select=".more-actions"></content>
       <template is="dom-if" if="[[hasPrefPolicyIndicator(pref.*)]]">
@@ -50,6 +50,7 @@
       </template>
       <paper-toggle-button id="control" checked="{{checked}}"
           on-change="notifyChangedByUserInteraction" aria-labelledby="label"
+          aria-describedby="subLabel"
           disabled="[[controlDisabled_(disabled, pref)]]">
       </paper-toggle-button>
     </div>

[Dan Beam, 2017-03-11 01:00:39]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-03-11 01:00:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/2743063004/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2017-03-11 01:01:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:56:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489194039698130,
"parent_rev": "8290ccacef2550eda0d2da5977b44cf80141541d", "commit_rev":
"eaeb5c6fe84d2ae813eef86e44a85b767c53b612"}

[commit-bot: I haz the power, 2017-03-11 01:57:48]

Description was changed from

==========
MD Settings: use the subLabel of <settings-toggle-button>s for the aria
description when the <paper-toggle-button> is focused

R=hcarmona@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: use the subLabel of <settings-toggle-button>s for the aria
description when the <paper-toggle-button> is focused

R=hcarmona@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2743063004
Cr-Commit-Position: refs/heads/master@{#456254}
Committed:
https://chromium.googlesource.com/chromium/src/+/eaeb5c6fe84d2ae813eef86e44a8...
==========

[commit-bot: I haz the power, 2017-03-11 01:57:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eaeb5c6fe84d2ae813eef86e44a8...