Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2743043002: Add a 400ms timeout for READY_TO_PAY service call. (Closed)

Created:
3 years, 9 months ago by please use gerrit instead
Modified:
3 years, 9 months ago
Reviewers:
gogerald1
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a 400ms timeout for READY_TO_PAY service call. Design doc: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE Flag (disabled by default): chrome://flags/#android-payment-apps BUG=700392 Review-Url: https://codereview.chromium.org/2743043002 Cr-Commit-Position: refs/heads/master@{#457240} Committed: https://chromium.googlesource.com/chromium/src/+/06d377270ab52ff547c6f79c240cdc01990c5215

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't set a timeout if service call failed. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java View 1 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
please use gerrit instead
Ganggui, ptal.
3 years, 9 months ago (2017-03-10 17:02:31 UTC) #2
gogerald1
lgtm with a comment, https://codereview.chromium.org/2743043002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java (right): https://codereview.chromium.org/2743043002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java#newcode203 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:203: mHandler.postDelayed(new Runnable() { move down ...
3 years, 9 months ago (2017-03-10 17:53:27 UTC) #3
please use gerrit instead
Will send to CQ after http://crrev.com/2734493002 lands. https://codereview.chromium.org/2743043002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java (right): https://codereview.chromium.org/2743043002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java#newcode203 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:203: mHandler.postDelayed(new Runnable() ...
3 years, 9 months ago (2017-03-13 14:08:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743043002/60001
3 years, 9 months ago (2017-03-15 21:17:41 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 22:35:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/06d377270ab52ff547c6f79c240c...

Powered by Google App Engine
This is Rietveld 408576698