Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/test/chromedriver/logging.cc

Issue 2743013002: Add webdriver endpoint to send custom debugger commands (Closed)
Patch Set: Adding e2e test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/logging.cc
diff --git a/chrome/test/chromedriver/logging.cc b/chrome/test/chromedriver/logging.cc
index afd73754ca19963be1f6f74e75d15fdb070a88a6..0a0bd39f2ef9b4330c84d926b3e980a1aaf9b6d8 100644
--- a/chrome/test/chromedriver/logging.cc
+++ b/chrome/test/chromedriver/logging.cc
@@ -22,6 +22,7 @@
#include "chrome/test/chromedriver/chrome/console_logger.h"
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/command_listener_proxy.h"
+#include "chrome/test/chromedriver/devtools_events_logger.h"
#include "chrome/test/chromedriver/performance_logger.h"
#include "chrome/test/chromedriver/session.h"
@@ -130,6 +131,7 @@ bool HandleLogMessage(int severity,
const char WebDriverLog::kBrowserType[] = "browser";
const char WebDriverLog::kDriverType[] = "driver";
const char WebDriverLog::kPerformanceType[] = "performance";
+const char WebDriverLog::kDevToolsType[] = "devtools";
bool WebDriverLog::NameToLevel(const std::string& name, Log::Level* out_level) {
for (size_t i = 0; i < arraysize(kNameToLevel); ++i) {
@@ -277,6 +279,13 @@ Status CreateLogs(const Capabilities& capabilities,
devtools_listeners.push_back(perf_log);
command_listeners.push_back(proxy);
}
+ } else if (type == WebDriverLog::kDevToolsType) {
+ WebDriverLog* log = new WebDriverLog(type, Log::kAll);
+ logs.push_back(log);
+ DevToolsEventsLogger* dt_events_log =
+ new DevToolsEventsLogger(log,
+ capabilities.devtools_events_logging_prefs);
+ devtools_listeners.push_back(dt_events_log);
} else if (type == WebDriverLog::kBrowserType) {
browser_log_level = level;
} else if (type != WebDriverLog::kDriverType) {

Powered by Google App Engine
This is Rietveld 408576698