Add webdriver endpoint to send custom debugger commands

chrome/test/chromedriver/chrome/web_view_impl.cc

Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index 167151bce9c5095df9a9107226799f6c16960b71..fd5cd266efb9f2e9ee49c6aa602501e2aa892601 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -199,6 +199,23 @@ Status WebViewImpl::Load(const std::string& url, const Timeout* timeout) {
   return client_->SendCommandWithTimeout("Page.navigate", params, timeout);
 }
 
+Status WebViewImpl::SendCommandAndGetResult(
+        std::string* cmd,
+        const base::DictionaryValue& params,
+        std::unique_ptr<base::Value>* value) {
+  std::unique_ptr<base::DictionaryValue> result;

[johnchen, 2017/04/26 05:17:47]

There should be no need to have a local variable to temporarily store the
result. Simply pass |value| as the last argument to
|client_->SendCommandAndGetResult|, so the result is directly written to its
destination. There is also no need to copy the result.

[em, 2017/04/27 05:02:09]

For some reason this doesn't seem to work, I get the following error:

../../chrome/test/chromedriver/chrome/web_view_impl.cc:206:65: error: cannot
initialize a parameter of type 'std::unique_ptr<base::DictionaryValue> *' with
an lvalue of type 'std::unique_ptr<base::Value> *'
  Status status = client_->SendCommandAndGetResult(cmd, params, value);
                                                                ^~~~~
../../chrome/test/chromedriver/chrome/devtools_client.h:51:47: note: passing
argument to parameter 'result' here
      std::unique_ptr<base::DictionaryValue>* result) = 0;

C++ is not exactly my strong suit so I may be making a very basic mistake here
:-/.

+  Status status = client_->SendCommandAndGetResult(*cmd, params, &result);
+  if (status.IsError())
+    return status;
+  value->reset(result->DeepCopy());
+  return Status(kOk);
+}
+
+Status WebViewImpl::SendCommand(std::string* cmd,
+                                const base::DictionaryValue& params) {
+    return client_->SendCommand(*cmd, params);
+}
+
 Status WebViewImpl::Reload(const Timeout* timeout) {
   base::DictionaryValue params;
   params.SetBoolean("ignoreCache", false);