Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6598)

Unified Diff: chrome/test/chromedriver/performance_logger.h

Issue 2743013002: Add webdriver endpoint to send custom debugger commands (Closed)
Patch Set: New DevToolsEventsLogger Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/performance_logger.h
diff --git a/chrome/test/chromedriver/performance_logger.h b/chrome/test/chromedriver/performance_logger.h
index 5bb58ae530423cef35c18b2393b68c41f4474a6c..c5dad205fa2e222ac24f8d40cd0c75a88a85e332 100644
--- a/chrome/test/chromedriver/performance_logger.h
+++ b/chrome/test/chromedriver/performance_logger.h
@@ -9,6 +9,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "chrome/test/chromedriver/base_logger.h"
#include "chrome/test/chromedriver/capabilities.h"
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
#include "chrome/test/chromedriver/command_listener.h"
@@ -27,7 +28,9 @@ struct Session;
// Also translates buffered trace events into Log messages of info level with
// the same structure if tracing categories are specified.
-class PerformanceLogger : public DevToolsEventListener, public CommandListener {
+class PerformanceLogger : public BaseLogger,
+ public DevToolsEventListener,
+ public CommandListener {
public:
// Creates a |PerformanceLogger| with default preferences that creates entries
// in the given Log object. The log is owned elsewhere and must not be null.
@@ -54,15 +57,6 @@ class PerformanceLogger : public DevToolsEventListener, public CommandListener {
Status BeforeCommand(const std::string& command_name) override;
private:
- void AddLogEntry(Log::Level level,
- const std::string& webview,
- const std::string& method,
- const base::DictionaryValue& params);
-
- void AddLogEntry(const std::string& webview,
- const std::string& method,
- const base::DictionaryValue& params);
-
// Enables Network, Page and Timeline domains according to |PerfLoggingPrefs|.
Status EnableInspectorDomains(DevToolsClient* client);
@@ -81,7 +75,6 @@ class PerformanceLogger : public DevToolsEventListener, public CommandListener {
Status CollectTraceEvents(); // Ditto.
Status IsTraceDone(bool* trace_done) const; // True if trace is not buffering.
- Log* log_; // The log where to create entries.
const Session* session_;
PerfLoggingPrefs prefs_;
DevToolsClient* browser_client_; // Pointer to browser-wide |DevToolsClient|.

Powered by Google App Engine
This is Rietveld 408576698