Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/test/chromedriver/performance_logger.cc

Issue 2743013002: Add webdriver endpoint to send custom debugger commands (Closed)
Patch Set: New DevToolsEventsLogger Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/performance_logger.cc
diff --git a/chrome/test/chromedriver/performance_logger.cc b/chrome/test/chromedriver/performance_logger.cc
index e80b5a95cfbc38401b9b1d55cfbf625b5200c20c..ff8209b39b02410c4750d60fef20986f12f9eafa 100644
--- a/chrome/test/chromedriver/performance_logger.cc
+++ b/chrome/test/chromedriver/performance_logger.cc
@@ -61,7 +61,7 @@ bool ShouldLogEvent(const std::string& method) {
} // namespace
PerformanceLogger::PerformanceLogger(Log* log, const Session* session)
- : log_(log),
+ : BaseLogger(log),
session_(session),
browser_client_(nullptr),
trace_buffering_(false) {}
@@ -69,7 +69,7 @@ PerformanceLogger::PerformanceLogger(Log* log, const Session* session)
PerformanceLogger::PerformanceLogger(Log* log,
const Session* session,
const PerfLoggingPrefs& prefs)
- : log_(log),
+ : BaseLogger(log),
session_(session),
prefs_(prefs),
browser_client_(nullptr),
@@ -110,30 +110,6 @@ Status PerformanceLogger::BeforeCommand(const std::string& command_name) {
return Status(kOk);
}
-void PerformanceLogger::AddLogEntry(
- Log::Level level,
- const std::string& webview,
- const std::string& method,
- const base::DictionaryValue& params) {
- base::DictionaryValue log_message_dict;
- log_message_dict.SetString("webview", webview);
- log_message_dict.SetString("message.method", method);
- log_message_dict.Set("message.params", params.DeepCopy());
- std::string log_message_json;
- base::JSONWriter::Write(log_message_dict, &log_message_json);
-
- // TODO(klm): extract timestamp from params?
- // Look at where it is for Page, Network, Timeline, and trace events.
- log_->AddEntry(level, log_message_json);
-}
-
-void PerformanceLogger::AddLogEntry(
- const std::string& webview,
- const std::string& method,
- const base::DictionaryValue& params) {
- AddLogEntry(Log::kInfo, webview, method, params);
-}
-
Status PerformanceLogger::EnableInspectorDomains(DevToolsClient* client) {
std::vector<std::string> enable_commands;
if (IsEnabled(prefs_.network))

Powered by Google App Engine
This is Rietveld 408576698