Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2742963002:
Use more accurate load start event in TabLoadObserver (Closed)
|
Created:
3 years, 9 months ago by shaktisahu Modified:
3 years, 9 months ago Reviewers:
Maria CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse more accurate load start event in TabLoadObserver
TabObserver.onPageLoadStarted is a better indicator of navigation start
event which is actually also used in ChromeTabUtils.
This fixes the tests that are failing when PlzNavigate mode enabled.
WebappModeTest#testWebappHandlesWindowOpenInTabbedMode
WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode
BUG=699383
Review-Url: https://codereview.chromium.org/2742963002
Cr-Commit-Position: refs/heads/master@{#456097}
Committed: https://chromium.googlesource.com/chromium/src/+/6fd7349089bc194ac6a08af6f94298987629dd9b
Patch Set 1 #Patch Set 2 : Test with PlzNavigate enabled #Patch Set 3 : Without plznavigate #
Messages
Total messages: 24 (20 generated)
The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use more accurate load finished event in TabLoadObserver BUG=699383 ========== to ========== Use more accurate load start event in TabLoadObserver BUG=699383 ==========
Description was changed from ========== Use more accurate load start event in TabLoadObserver BUG=699383 ========== to ========== Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indication of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG=699383 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indication of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG=699383 ========== to ========== Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indicator of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG=699383 ==========
Description was changed from ========== Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indicator of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG=699383 ========== to ========== Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indicator of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests that are failing when PlzNavigate mode enabled. WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG=699383 ==========
shaktisahu@chromium.org changed reviewers: + mariakhomenko@chromium.org
PTAL
lgtm
The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shaktisahu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489168033751710,
"parent_rev": "75f655ce3baead660fc6fc9ef5b2f05f16458ea6", "commit_rev":
"6fd7349089bc194ac6a08af6f94298987629dd9b"}
Message was sent while issue was closed.
Description was changed from ========== Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indicator of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests that are failing when PlzNavigate mode enabled. WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG=699383 ========== to ========== Use more accurate load start event in TabLoadObserver TabObserver.onPageLoadStarted is a better indicator of navigation start event which is actually also used in ChromeTabUtils. This fixes the tests that are failing when PlzNavigate mode enabled. WebappModeTest#testWebappHandlesWindowOpenInTabbedMode WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode BUG=699383 Review-Url: https://codereview.chromium.org/2742963002 Cr-Commit-Position: refs/heads/master@{#456097} Committed: https://chromium.googlesource.com/chromium/src/+/6fd7349089bc194ac6a08af6f942... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6fd7349089bc194ac6a08af6f942... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
