Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2742873002: Convert non-WHATWG text encoding to ASCII (Closed)

Created:
3 years, 9 months ago by Jinsuk Kim
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Convert non-WHATWG text encoding to ASCII CED is returning text encodings not supported by WHATWG standard, which Blink refused to accept. It can cause an unexpected bug. This CL converts those encoding to ASCII so that raw bytes of the text remain intact. BUG=698605 NOTRY=true NOPRESUBMIT=true TBR=tkent@chromium.org Review-Url: https://codereview.chromium.org/2737033003 Cr-Commit-Position: refs/heads/master@{#455560} (cherry picked from commit a86006db0adbe5bda6789d2a14d0805ce6273596) Review-Url: https://codereview.chromium.org/2742873002 . Cr-Commit-Position: refs/branch-heads/3029@{#97} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/4c33f0d70750323bef4101380076570d1f2e803c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp View 1 chunk +36 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextEncodingDetectorTest.cpp View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Jinsuk Kim
Committed patchset #1 (id:1) manually as 4c33f0d70750323bef4101380076570d1f2e803c.
3 years, 9 months ago (2017-03-09 23:26:19 UTC) #2
tkent
3 years, 9 months ago (2017-03-10 00:23:59 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698