Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2742853002: Fix stopped navigations not having the correct error code in their navigation handle. (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG=645983 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2742853002 Cr-Commit-Position: refs/heads/master@{#455930} Committed: https://chromium.googlesource.com/chromium/src/+/0299edae682a3dd0c5f4ffd3fddde60b124695db

Patch Set 1 : with PlzNavigate #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 25 (21 generated)
jam
3 years, 9 months ago (2017-03-09 22:33:41 UTC) #15
nasko
LGTM
3 years, 9 months ago (2017-03-10 00:27:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742853002/20001
3 years, 9 months ago (2017-03-10 00:43:09 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 00:50:16 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0299edae682a3dd0c5f4ffd3fddd...

Powered by Google App Engine
This is Rietveld 408576698