|
|
DescriptionFix stopped navigations not having the correct error code in their navigation handle.
This fixes
ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad
ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_
ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi
ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_
ClientOnReceivedError2Test#testNotCalledOnStopLoading
ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer}
with PlzNavigate.
BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2742853002
Cr-Commit-Position: refs/heads/master@{#455930}
Committed: https://chromium.googlesource.com/chromium/src/+/0299edae682a3dd0c5f4ffd3fddde60b124695db
Patch Set 1 : with PlzNavigate #Patch Set 2 #
Messages
Total messages: 25 (21 generated)
Description was changed from ========== the # Enter a description of the change. Fix ClientOnPageFinishedTest failures with PlzNavigate. BUG= ========== to ========== the # Enter a description of the change. Fix ClientOnPageFinishedTest failures with PlzNavigate. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== the # Enter a description of the change. Fix ClientOnPageFinishedTest failures with PlzNavigate. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} PolicyUrlFilteringTest#testWhitelistedUrl BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} PolicyUrlFilteringTest#testWhitelistedUrl BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} PolicyUrlFilteringTest#testWhitelistedUrl AwSettingsTest#testUserAgentWithTestServer AwSettingsTest#testUserAgentWithTestServer with {--webview-sandboxed-renderer} AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload with {--webview-sandboxed-renderer} BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} PolicyUrlFilteringTest#testWhitelistedUrl AwSettingsTest#testUserAgentWithTestServer AwSettingsTest#testUserAgentWithTestServer with {--webview-sandboxed-renderer} AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload with {--webview-sandboxed-renderer} BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} PolicyUrlFilteringTest#testWhitelistedUrl AwSettingsTest#testUserAgentWithTestServer AwSettingsTest#testUserAgentWithTestServer with {--webview-sandboxed-renderer} AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload with {--webview-sandboxed-renderer} ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Fix ClientOnPageFinishedTest failures with PlzNavigate. ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden ClientOnPageFinishedTest_testCalledAfterRedirectedUrlIsOverridden_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_ AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_ AwSettingsTest#testAppCacheWithTwoViews AwSettingsTest#testAppCacheWithTwoViews with {--webview-sandboxed-renderer} PolicyUrlFilteringTest#testWhitelistedUrl AwSettingsTest#testUserAgentWithTestServer AwSettingsTest#testUserAgentWithTestServer with {--webview-sandboxed-renderer} AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload AwSettingsTest#testUpdatingUserAgentWhileLoadingCausesReload with {--webview-sandboxed-renderer} ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG=BUG=645983 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
jam@chromium.org changed reviewers: + nasko@chromium.org
Description was changed from ========== Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG=BUG=645983 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG=645983 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489106548529380, "parent_rev": "258758c687d31cc18e1f9f0395a8714df0187202", "commit_rev": "0299edae682a3dd0c5f4ffd3fddde60b124695db"}
Message was sent while issue was closed.
Description was changed from ========== Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG=645983 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix stopped navigations not having the correct error code in their navigation handle. This fixes ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad ClientOnPageFinishedTest_testCalledOnCancelingProvisionalLoad_with__--webview-sandboxed-renderer_ ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi ClientOnPageFinishedTest_testNotCalledOnDomModificationWithJavascriptUrlAfterNonCommittedLoadFromApi_with__--webview-sandboxed-renderer_ ClientOnReceivedError2Test#testNotCalledOnStopLoading ClientOnReceivedError2Test#testNotCalledOnStopLoading with {--webview-sandboxed-renderer} with PlzNavigate. BUG=645983 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2742853002 Cr-Commit-Position: refs/heads/master@{#455930} Committed: https://chromium.googlesource.com/chromium/src/+/0299edae682a3dd0c5f4ffd3fddd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0299edae682a3dd0c5f4ffd3fddd...
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |