[inspector] merged IsSubjectToDebugging and IsBlackboxed and fixed issue

[inspector] merged IsSubjectToDebugging and IsBlackboxed and fixed issue

- additionally doesn't deoptimize function in HandleDebugBreak for debugger statements inside of blackboxed code.

BUG=none
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2742843003
Cr-Commit-Position: refs/heads/master@{#43724}
Committed: https://chromium.googlesource.com/v8/v8/+/fb147b0ef102b78e72c4c194034d1d72706e3315

[kozy, 2017-03-10 02:25:30]

Description was changed from

==========
[inspector] merged IsSubjectToDebugging and IsBlackboxed and fixed issue

BUG=
==========

to

==========
[inspector] merged IsSubjectToDebugging and IsBlackboxed and fixed issue

- additionally doesn't deoptimize function in HandleDebugBreak for debugger
statements inside of blackboxed code.

BUG=none
R=yangguo@chromium.org
==========

[kozy, 2017-03-10 02:25:31]

kozyatinskiy@chromium.org changed reviewers:
+ yangguo@chromium.org

[kozy, 2017-03-10 02:42:00]

Yang, please take a look!

[Yang, 2017-03-10 13:50:37]

lgtm

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc
File src/debug/debug.cc (left):

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc#oldc...
src/debug/debug.cc:1982: if (script->type() == i::Script::TYPE_NORMAL) {
Let's check this in a DCHECK

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc#newc...
src/debug/debug.cc:1737: StackTraceFrameIterator it(isolate_);
Do we want to include wasm frame in this? Why StackTraceFrameIterator instead of
JavaScriptFrameIterator?

[kozy, 2017-03-10 17:20:56]

Patchset #5 (id:80001) has been deleted

[kozy, 2017-03-10 17:21:05]

all done.

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc
File src/debug/debug.cc (left):

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc#oldc...
src/debug/debug.cc:1982: if (script->type() == i::Script::TYPE_NORMAL) {
On 2017/03/10 13:50:37, Yang wrote:
> Let's check this in a DCHECK

Done.

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2742843003/diff/60001/src/debug/debug.cc#newc...
src/debug/debug.cc:1737: StackTraceFrameIterator it(isolate_);
On 2017/03/10 13:50:37, Yang wrote:
> Do we want to include wasm frame in this? Why StackTraceFrameIterator instead
of
> JavaScriptFrameIterator?

For blackboxing I'd like to include the same frames that is exposed in stack
trace, so I prefer to use StackTraceFrameIterator then JavaScriptFrameIterator,
but we need to ignore wasm frames currently, because we don't support
blackboxing of wasm modules.

[kozy, 2017-03-10 17:21:08]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-10 17:21:09]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2742843003/#ps100001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-10 17:21:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 17:44:36]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489166468658750,
"parent_rev": "6b15cdb20069642043209a1469f269239495239a", "commit_rev":
"fb147b0ef102b78e72c4c194034d1d72706e3315"}

[commit-bot: I haz the power, 2017-03-10 17:44:41]

Description was changed from

==========
[inspector] merged IsSubjectToDebugging and IsBlackboxed and fixed issue

- additionally doesn't deoptimize function in HandleDebugBreak for debugger
statements inside of blackboxed code.

BUG=none
R=yangguo@chromium.org
==========

to

==========
[inspector] merged IsSubjectToDebugging and IsBlackboxed and fixed issue

- additionally doesn't deoptimize function in HandleDebugBreak for debugger
statements inside of blackboxed code.

BUG=none
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2742843003
Cr-Commit-Position: refs/heads/master@{#43724}
Committed:
https://chromium.googlesource.com/v8/v8/+/fb147b0ef102b78e72c4c194034d1d72706...
==========

[commit-bot: I haz the power, 2017-03-10 17:44:42]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/fb147b0ef102b78e72c4c194034d1d72706...