Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2742833006: [ash-md] Changed opaque shelf color darkening from 90% to 70%. (Closed)

Created:
3 years, 9 months ago by bruthig
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Changed opaque shelf color darkening from 90% to 70%. Darkening the shelf by 90% for the --ash-shelf-color experiment was too close to black. Changing to 70% will make the color more visible. TBR=sky@chromium.org BUG=595010 Review-Url: https://codereview.chromium.org/2742833006 Cr-Commit-Position: refs/heads/master@{#456183} Committed: https://chromium.googlesource.com/chromium/src/+/786f4f5950e27410960fcb188dd4db4af1575656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/shelf/shelf_constants.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
bruthig
sky@, I've TBR'ed you on this simple constant change. Take a look if you wish ...
3 years, 9 months ago (2017-03-10 21:39:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742833006/1
3 years, 9 months ago (2017-03-10 21:39:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/786f4f5950e27410960fcb188dd4db4af1575656
3 years, 9 months ago (2017-03-10 22:11:44 UTC) #11
sky
3 years, 9 months ago (2017-03-11 00:10:51 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698