Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/offline_pages/core/downloads/download_ui_adapter.cc

Issue 2742833004: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/downloads/download_ui_adapter.cc
diff --git a/components/offline_pages/core/downloads/download_ui_adapter.cc b/components/offline_pages/core/downloads/download_ui_adapter.cc
index 85433146f1a4c21d726a319e3ded1025c65916d0..35910a0fe729a16d970d9d307ebd93ee27345993 100644
--- a/components/offline_pages/core/downloads/download_ui_adapter.cc
+++ b/components/offline_pages/core/downloads/download_ui_adapter.cc
@@ -164,6 +164,22 @@ void DownloadUIAdapter::OnChanged(const SavePageRequest& request) {
observer.ItemUpdated(download_ui_item);
}
+void DownloadUIAdapter::OnNetworkProgress(const SavePageRequest& request,
+ int64_t received_bytes) {
+ for (auto& item : items_) {
+ if (item.second->is_request &&
+ item.second->offline_id == request.request_id()) {
+ if (received_bytes == item.second->ui_item->download_progress_bytes)
+ return;
+
+ item.second->ui_item->download_progress_bytes = received_bytes;
+ for (Observer& observer : observers_)
+ observer.ItemUpdated(*(item.second->ui_item));
+ return;
+ }
+ }
+}
+
void DownloadUIAdapter::TemporaryHiddenStatusChanged(
const ClientId& client_id) {
bool hidden = delegate_->IsTemporarilyHiddenInUI(client_id);
@@ -226,19 +242,6 @@ int64_t DownloadUIAdapter::GetOfflineIdByGuid(const std::string& guid) const {
return 0;
}
-void DownloadUIAdapter::UpdateProgress(int64_t offline_id, int64_t bytes) {
- for (auto& item : items_) {
- if (item.second->is_request && item.second->offline_id == offline_id) {
- if (bytes == item.second->ui_item->download_progress_bytes)
- return;
-
- item.second->ui_item->download_progress_bytes = bytes;
- for (Observer& observer : observers_)
- observer.ItemUpdated(*(item.second->ui_item));
- }
- }
-}
-
// Note that several LoadCache calls may be issued before the async GetAllPages
// comes back.
void DownloadUIAdapter::LoadCache() {

Powered by Google App Engine
This is Rietveld 408576698