Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2742783004: Switch tab launch type for NTP on inactivity experiment. (Closed)

Created:
3 years, 9 months ago by Ted C
Modified:
3 years, 9 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch tab launch type for NTP on inactivity experiment. FROM_CHROME_UI results in animations that we do not want and FROM_EXTERNAL_APP allows the NTP to be closed if you hit back, which I think is nice since we are creating a tab without any user gesture so making it discardable seems correct. BUG=695306 Review-Url: https://codereview.chromium.org/2742783004 Cr-Commit-Position: refs/heads/master@{#456233} Committed: https://chromium.googlesource.com/chromium/src/+/1a8b3d0add5495ca39b37ef772ea725f03c478cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 9 months ago (2017-03-10 21:51:13 UTC) #2
Yusuf
lgtm
3 years, 9 months ago (2017-03-10 23:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742783004/1
3 years, 9 months ago (2017-03-10 23:44:51 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:31:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a8b3d0add5495ca39b37ef772ea...

Powered by Google App Engine
This is Rietveld 408576698