Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2742783003: Removed CopyState() from NavigationManager, as it is unused. (Closed)

Created:
3 years, 9 months ago by kkhorimoto
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed CopyState() from NavigationManager, as it is unused. BUG=454984 Review-Url: https://codereview.chromium.org/2742783003 Cr-Commit-Position: refs/heads/master@{#455932} Committed: https://chromium.googlesource.com/chromium/src/+/7b03ac34ae9d5b9dcc7e238cd28c613550492fab

Patch Set 1 #

Patch Set 2 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -29 lines) Patch
M ios/web/navigation/crw_session_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 1 chunk +0 lines, -19 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
kkhorimoto
3 years, 9 months ago (2017-03-09 23:23:33 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 9 months ago (2017-03-09 23:35:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742783003/20001
3 years, 9 months ago (2017-03-10 00:34:59 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 00:54:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b03ac34ae9d5b9dcc7e238cd28c...

Powered by Google App Engine
This is Rietveld 408576698